Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC

[Ray Jui]

Hi Linus,

On 12/10/2015 8:50 AM, Linus Walleij wrote:
> On Mon, Nov 30, 2015 at 6:05 PM, Ray Jui <rjui@xxxxxxxxxxxx> wrote:
> > Hi Linus,
> >
> > On 11/30/2015 4:49 AM, Linus Walleij wrote:
> > > On Fri, Nov 20, 2015 at 6:57 PM, Yendapally Reddy Dhananjaya Reddy
> > > <yrdreddy@xxxxxxxxxxxx> wrote:
> > >
> > > > This adds the initial support of the Broadcom NSP pinmux driver.
> > > >
> > > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@xxxxxxxxxxxx>
> > >
> > >
> > > So what does Ray and Stephen say about this?
> > >
> > > Is the hardware unique enough to warrant its own driver?
> > >
> > > Or should it utilize/extend one of the existing Broadcom
> > > drivers?
> >
> >
> > Currently, the IOMUX configurations in Cygnus, NSP, and NS2 are completely
> > different and require a separate driver to each of these SoCs. We now
> > realize the shortcomings and have been communicating with our ASIC team.
> > We'd like to fix this for the next-gen of our SoC. We are driving towards
> > using a register layout that will allow us to use just "pinctrl-single" and
> > "pinconf-single."
>
> OK can you provide your reviews for the NSP driver?
>
> Yours,
> Linus Walleij

Yes, I just replied to the email thread with my "Reviewed-by". In fact, 
both Scott and I reviewed the patches internally in Broadcom before they 
went out to public.

Thanks,

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/