Re: Source code review around jump label usage

From: Julia Lawall
Date: Fri Dec 11 2015 - 07:15:05 EST


> Do any of these numbers indicate update candidates which correspond to the
> "one error jump label bug" symptom that is mentioned in the Linux coding
> style documentation?

I don't think that numbers could indicate that. The point of that is a
single label followed by a bunch of ifs, or by calls to functions that
perform tests on input validity. That is, it is the content of the code
that causes the problem, not its size. Dan also discourages the use of
labels like out, that don't indicate anything about anything, or
kmalloc_err, which don't indicate anything about what happens at the label
target.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/