Re: [PATCH] bpf: constify bpf_verifier_ops structure

From: Steven Rostedt
Date: Fri Dec 11 2015 - 13:13:07 EST


On Fri, 11 Dec 2015 18:35:59 +0100
Julia Lawall <Julia.Lawall@xxxxxxx> wrote:

> This bpf_verifier_ops structure is never modified, like the other
> bpf_verifier_ops structures, so declare it as const.
>
> Done with the help of Coccinelle.

Thanks, I'll add this to my 4.5 queue.

-- Steve

>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> kernel/trace/bpf_trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index 4228fd3..45dd798 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -316,7 +316,7 @@ static bool kprobe_prog_is_valid_access(int off, int size, enum bpf_access_type
> return true;
> }
>
> -static struct bpf_verifier_ops kprobe_prog_ops = {
> +static const struct bpf_verifier_ops kprobe_prog_ops = {
> .get_func_proto = kprobe_prog_func_proto,
> .is_valid_access = kprobe_prog_is_valid_access,
> };

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/