Re: [dm-devel] [PATCH 0/15] copy offload patches

From: Christoph Hellwig
Date: Fri Dec 11 2015 - 14:55:22 EST


On Thu, Dec 10, 2015 at 11:06:04PM -0600, Mike Christie wrote:
>
> 2. Start REQ_OP_READ off at non-zero to try and shake out code that was
> not converted.
>
> There are a several places where we assume reads are zero and writes are
> 1 for things like indexing in arrays (like blktrace's ddir_act or dm
> starts), passing into block functions (like nvme_alloc_request's call of
> blk_mq_alloc_request), and if/else's. I am not done fixing all of them
> and testing.

If this turns out to be too painful we should just skip it. I though it
would be a nie debugging aid, but we don't need to do it at any cost.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/