Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

From: Sergei Shtylyov
Date: Fri Dec 11 2015 - 15:57:32 EST


On 12/11/2015 10:56 PM, David Eccher wrote:

Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769,
hence it must exit with spinlock held to avoid double unlock in dev_config.

Signed-off-by: David Eccher <d.eccher@xxxxxxxxx>
drivers/usb/gadget/legacy/inode.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
index f454c7a..b968c25 100644
--- a/drivers/usb/gadget/legacy/inode.c
+++ b/drivers/usb/gadget/legacy/inode.c
@@ -1144,6 +1144,7 @@ ep0_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
} else
retval = len;

+ spin_lock_irq (&dev->lock);

I guess you hadn't run the patch thru scripts/

MBR, Sergei

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at