Re: [PATCH net] stmmac: dwmac-sunxi: Call exit cleanup function in probe error path

From: David Miller
Date: Mon Dec 14 2015 - 16:12:30 EST


From: Chen-Yu Tsai <wens@xxxxxxxx>
Date: Fri, 11 Dec 2015 18:03:49 +0800

> dwmac-sunxi has 2 callbacks that were called from stmmac_platform as
> part of the probe and remove sequences.
>
> Ater the conversion of dwmac-sunxi into a standalone platform driver,
> the .init function is called before calling into the stmmac driver
> core, but .exit is not called to clean up if stmmac returns an error.
>
> This patch fixes the probe error path. This properly cleans up and
> releases resources when the driver core fails to probe.
>
> Cc: Joachim Eastwood <manabian@xxxxxxxxx>
> Fixes: 9a9e9a1edee8 ("stmmac: dwmac-sunxi: turn setup callback into a
> probe function")
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/