Re: [PATCH v2 2/2] gpio: pxa: add pin control gpio direction and request

From: Linus Walleij
Date: Tue Dec 15 2015 - 08:17:46 EST

On Sat, Dec 12, 2015 at 11:55 PM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:

> If a pin control driver is available, use it to change the gpio
> direction. If not fallback to directly manipulating the gpio direction
> register.
> The reason to use the pin control driver first is that pin control in
> pxa2xx architecture implies changing the gpio direction, even for non
> gpio functions. In order to do it atomically, only one driver should
> control the gpio direction, and if a pin controller is available, it has
> to be him.
> There is a small catch : if CONFIG_PINCTRL is selected, then a pinctrl
> driver has to be probed. If not, gpio_request() will return
> -EPROBE_DEFER as pinctrl_request_gpio() returns it in that case.
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> ---
> Since v1: expand commit message to state the gpio possible breakage if
> CONFIG_PINCTRL is selected and no pinctrl driver is built.

Patch applied.

Now you only need to send the incremental diff for patch 1/2.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at