Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes

From: Mark Rutland
Date: Tue Dec 15 2015 - 09:53:03 EST


On Tue, Dec 15, 2015 at 10:47:09PM +0800, Jisheng Zhang wrote:
> Dear Arnd,
>
> On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote:
>
> > On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> > > - compatible = "arm,armv8-pmuv3";
> > > + compatible = "arm,cortex-a53-pmu";
> > >
> >
> > Should this list both?
>
> IMHO, we don't need to list both. The pmu binding document also says:
> "compatible : should be one of ...."
>
> Dear Mark,
>
> Could you please give suggestions?

That should probably reads as "should contain at least one of".

It's probably best to keep "arm,armv8-pmuv3" as a fallback in the
compatible list.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/