Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

From: Lee Duncan
Date: Thu Dec 17 2015 - 14:25:47 EST


On 12/14/2015 05:55 PM, Martin K. Petersen wrote:
>>>>>> "Hannes" == Hannes Reinecke <hare@xxxxxxx> writes:
>
>>> I'm not opposed to having the module option if others (Martin?) feel
>>> they need it, but generally I think it's better to keep things as
>>> simple as possible. So, unless there are strong objections, I would
>>> say no.
>
> Hannes> Agreeing with Ewan here.
>
> Hannes> I guess it's up to you to tell us whether you absolutely need a
> Hannes> module parameter ...
>
> Still not a big ida fan but since the most people seem to be in favor of
> this I guess I'll have to bite the bullet.
>
> I don't see much value in the module parameter since it will require
> customers to tweak their configs and reproduce. Not worth the hassle.
>

Thank you Martin. I'll look at further cleaning up the host module, but
I think this still much better than leaving the code as is.

--
Lee Duncan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/