Re: [PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie

From: Sergei Shtylyov
Date: Fri Dec 18 2015 - 06:33:06 EST


Hello.

On 12/18/2015 1:21 PM, Kishon Vijay Abraham I wrote:

Add new device tree node for the control module register space where
PCIe registers are present.

Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
---
arch/arm/boot/dts/dra7.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index fe99231..e38f63f 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -155,6 +155,11 @@
compatible = "syscon";
reg = <0x1c04 0x0020>;
};
+
+ scm_conf_pcie: tisyscon@1c24 {

Please use the generic node names as the ePAPR standard says.

something like scm_conf_pcie: syscon@1c24??

Yes, though "system-controller" would be probably more in line with what ePAPR has standardized.

Thanks
Kishon

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/