Re: [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime

[Guenter Roeck]

On 12/22/2015 02:05 PM, Tomas Winkler wrote:

>  > Do you see a situation where holding the lock between calls into the driver
>  > might be a problem ?
>
> I don't think u are holding the lock now in watchdog_unregister when WDOG_UNREGISTERED was dropped.

the lock is held while clearing the pointers:

	mutex_lock(&wd_data->lock);
        wd_data->wdd = NULL;
        wdd->wd_data = NULL;
        mutex_unlock(&wd_data->lock);

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/