Re: [PATCH v2] um: Fix build error and kconfig for i386

[Josh Triplett]

On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
> Fix build error by selecting COREDUMP when X86_32 is selected:
> 
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
> 
> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxx>
> Cc: Jeff Dike <jdike@xxxxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> Cc: Michal Marek <mmarek@xxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

I suppose um doesn't care deeply about binary size, but ideally I would
suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.

>  arch/x86/um/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
> index ed56a1c4ae73..bb7cd8b38043 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -26,6 +26,7 @@ config X86_32
>  	select CLONE_BACKWARDS
>  	select OLD_SIGSUSPEND3
>  	select OLD_SIGACTION
> +	select COREDUMP
>  
>  config X86_64
>  	def_bool 64BIT
> -- 
> 2.6.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/