Re: [PATCH v3] um: Fix build error and kconfig for i386

[Josh Triplett]

On Fri, Dec 25, 2015 at 07:45:41PM +0100, Mickaël Salaün wrote:
> 
> On 25/12/2015 02:34, Josh Triplett wrote:
> > On Thu, Dec 24, 2015 at 01:12:11PM +0100, Mickaël Salaün wrote:
> >> Fix build error by generating elfcore.o only when ELF_CORE (depending on
> >> COREDUMP) is selected:
> >>
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> >> (.text+0x3e62): undefined reference to `dump_emit'
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> >> (.text+0x3eef): undefined reference to `dump_emit'
> >>
> >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> >> Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxx>
> >> Cc: Jeff Dike <jdike@xxxxxxxxxxx>
> >> Cc: Richard Weinberger <richard@xxxxxx>
> >> Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> >> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> >> Cc: Michal Marek <mmarek@xxxxxxx>
> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > 
> > It looks like ELF_CORE depends on COREDUMP, but not on BINFMT_ELF.
> > Should it?  What happens if you build this with ELF_CORE=y and
> > BINFMT_ELF=n?  Does that configuration even make sense?
> 
> It build fine with ELF_CORE=y and BINFMT_ELF=n but does not seem
> useful. Nevertheless, it's the same for all architectures (cf.
> init/Kconfig): ELF_CORE only depends on COREDUMP.

As long as that builds, then this patch doesn't introduce an
un-buildable Kconfig configuration, so it seems reasonable.  Thanks
again for producing a new version.

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/