Re: [PATCH 09/10] watchdog: cadence_wdt: use to_platform_device()

From: Guenter Roeck
Date: Sun Dec 27 2015 - 10:27:28 EST


On Sun, Dec 27, 2015 at 09:15:47PM +0800, Geliang Tang wrote:
> Use to_platform_device() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangtang@xxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> drivers/watchdog/cadence_wdt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index abf64eb..4dda902 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -421,8 +421,7 @@ static void cdns_wdt_shutdown(struct platform_device *pdev)
> */
> static int __maybe_unused cdns_wdt_suspend(struct device *dev)
> {
> - struct platform_device *pdev = container_of(dev,
> - struct platform_device, dev);
> + struct platform_device *pdev = to_platform_device(dev);
> struct cdns_wdt *wdt = platform_get_drvdata(pdev);
>
> cdns_wdt_stop(&wdt->cdns_wdt_device);
> @@ -440,8 +439,7 @@ static int __maybe_unused cdns_wdt_suspend(struct device *dev)
> static int __maybe_unused cdns_wdt_resume(struct device *dev)
> {
> int ret;
> - struct platform_device *pdev = container_of(dev,
> - struct platform_device, dev);
> + struct platform_device *pdev = to_platform_device(dev);
> struct cdns_wdt *wdt = platform_get_drvdata(pdev);
>
> ret = clk_prepare_enable(wdt->clk);
> --
> 2.5.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/