Re: [PATCH] Fix ld-version.sh to handle large 3rd version part

From: Andi Kleen
Date: Sun Dec 27 2015 - 17:37:36 EST


On Sat, Dec 26, 2015 at 10:47:52PM +0000, James Hogan wrote:
> The ld-version.sh script doesn't handle versions with large (>= 10) 3rd
> version components, because the 2nd component is only multiplied by 10
> times that of the 3rd component.
>
> For example the following version string:
> GNU ld (Codescape GNU Tools 2015.06-05 for MIPS MTI Linux) 2.24.90
>
> gives a bogus version number:
> 20000000
> + 2400000
> + 900000 = 23300000
>
> Breakage, confusion and mole-whacking ensues.

Thanks. Looks good. I'll fix the LTO tree.

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/