Re: [Xen-devel] [PATCH RFC 3/3] xen/Kconfig: add XEN_TIME_VSYSCALL option

From: Joao Martins
Date: Mon Jan 04 2016 - 15:41:52 EST




On 01/04/2016 04:15 PM, Boris Ostrovsky wrote:
> On 01/04/2016 11:12 AM, David Vrabel wrote:
>> On 28/12/15 21:52, Joao Martins wrote:
>>> This option enables support for pvclock vsyscall/vdso
>>> support on Xen. Default is off, since Xen doesn't
>>> expose yet the PVCLOCK_TSC_STABLE_BIT flag.
>> Do we need a Kconfig option for this? I think this should always be
>> enabled.
>>
>> The kernel support won't be merged until the hypervisor changes have
>> been accepted.
> I agree. xen_setup_vsyscall_time_info() will (harmlessly) fail if
> PVCLOCK_TSC_STABLE_BIT is not set.
>
OK, I will remove this patch then.

I only added it because even if PVCLOCK_TSC_STABLE_BIT is not supported it would
leave the pvti registered with Xen during domain lifetime [it seems we can't
unregister the pvti]. But perhaps this is not a concern.

> -boris
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/