Re: [PATCH 4.2.y-ckt 009/211] xhci: don't finish a TD if we get a short transfer event mid TD

From: Ben Hutchings
Date: Wed Jan 06 2016 - 12:05:54 EST


On Tue, 2016-01-05 at 11:41 -0800, Kamal Mostafa wrote:
> 4.2.8-ckt1 -stable review patch.ÂÂIf anyone has any objections, please let me know.
>
> ------------------
>
> From: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
>
> commit e210c422b6fdd2dc123bedc588f399aefd8bf9de upstream.
>
> If the difference is big enough between the bytes asked and received
> in a bulk transfer we can get a short transfer event pointing to a TRB in
> the middle of the TD. We don't want to handle the TD yet as we will anyway
> receive a new event for the last TRB in the TD.
>
> Hold off from finishing the TD and removing it from the list until we
> receive an event for the last TRB in the TD
>
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> [ kamal: backport to 4.2-stable: context ]
> Signed-off-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
[...]

This causes regressions (see https://bugs.debian.org/808602Âand
https://bugs.debian.org/808953 ) so please hold off until there's a
complete fix upstream.

Ben.

--
Ben Hutchings
It is easier to write an incorrect program than to understand a correct one.

Attachment: signature.asc
Description: This is a digitally signed message part