Re: [PATCH 01/32] mm, gup: introduce concept of "foreign" get_user_pages()

From: Dave Hansen
Date: Wed Jan 06 2016 - 12:43:41 EST


On 01/05/2016 02:51 AM, Vlastimil Babka wrote:
>
> Changelog doesn't mention that get_user_pages_unlocked() is also changed
> to be effectively get_current_user_pages_unlocked(). It's a bit
> non-obvious and the inconsistent naming is unfortunate, but I can see
> how get_current_user_pages_unlocked() would be too long, and just
> deleting the parameters from get_user_pages() would be too large and
> intrusive. But please mention this in changelog?

Thanks for the review! Good point about the churn there. I'll add some
changelog comments.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/