Re: [PATCH 1/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl
From: Christoph Hellwig
Date: Fri Jan 08 2016 - 04:08:58 EST
On Fri, Jan 08, 2016 at 12:47:39AM -0800, Nicholas A. Bellinger wrote:
> Actually no, they do not. That's the way that everything outside of
> tcm_fc + ib_srpt driver code has already worked for a long time.
Another reason to introduce a helper to enforce that ordering!
Everything but iscsi and qla2xxx is absolutely trivial to convert.
qla2xxx needs some work, but I think it's actually wrong currently
as it sets the s_id and loop_id unconditionally even if we're
reusing an existing node ACL. iscsi is black magic as usual, so I'm
a little lost..