Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

[David.Wu]

Hi Wolfram, Andy

Thanks for your suggestion.
I will  use i2c_parse_fw_timings() function to replace it.

å 2016/1/5 3:40, Wolfram Sang åé:
> > > > +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long
> > > > scl_rate,
> > > > +                                unsigned long scl_rise_ns,
> > > > +                                unsigned long scl_fall_ns,
> > > > +                                unsigned long sda_fall_ns,
> > Wolfram did some sturct to assign the parameters from device properties.
> > It might be re-used here.
> Yes, I think it makes sense to convert the driver first to use
> the new i2c_parse_fw_timings() function and see if it fits (or if we need
> to extend it perhaps).
>
> David, does this make sense to you?