Re: [PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio
From: Mike Christie
Date: Sat Jan 09 2016 - 19:46:19 EST
On 01/09/2016 07:34 AM, Christoph Hellwig wrote:
>> > diff --git a/block/blk-flush.c b/block/blk-flush.c
>> > index 9c423e5..e092e13 100644
>> > --- a/block/blk-flush.c
>> > +++ b/block/blk-flush.c
>> > @@ -484,8 +484,9 @@ int blkdev_issue_flush(struct block_device *bdev, gfp_t gfp_mask,
>> > bio = bio_alloc(gfp_mask, 0);
>> > bio->bi_bdev = bdev;
>> > + bio->bi_rw |= WRITE_FLUSH;
> Shouldn't the |= be a = here and in many other places?
Yeah, I was trying to merge bi_rw and bio_flags. I am not going to send
that. I will fix up the patchset.