Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function

From: Andrew Lunn
Date: Sun Jan 10 2016 - 12:21:26 EST


> drivers/net/ethernet/amd/au1000_eth.c: /* WARNING: bus->phy_map[phy_addr].attached_dev == dev does
> [ no idea what to do with that comment ]

That comment is very generic, it applies to all MDIO devices. So i'm
tempted to remove it. I will send a patch, probably tomorrow.

> drivers/net/ethernet/broadcom/sb1250-mac.c: phy_dev = sc->mii_bus->phy_map[i];
> [ can use phy_find_first ]

Yes, phy_find_first.

> drivers/staging/netlogic/xlr_net.c: struct phy_device *phydev = priv->mii_bus->phy_map[priv->phy_addr];
> [ several ]

Odd that i missed that file for phy_map, but did patch it for
phydev_name().

I will send a patch for that, but probably tomorrow.

Andrew