Re: [PATCH] net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory

From: David Miller
Date: Sun Jan 10 2016 - 18:01:43 EST


From: Sasha Levin <sasha.levin@xxxxxxxxxx>
Date: Thu, 7 Jan 2016 14:52:43 -0500

> proc_dostring() needs an initialized destination string, while the one
> provided in proc_sctp_do_hmac_alg() contains stack garbage.
>
> Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
> accessing invalid memory.
>
> Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
> Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx>

Applied and queued up for -stable, thanks.