Re: [PATCH v2 trivial] include/linux/dcache.h: Cleanup code and comments

[David Howells]

chengang@xxxxxxxxxxxxxxxx wrote:

> -#define DCACHE_MISS_TYPE		0x00000000 /* Negative dentry (maybe fallthru to nowhere) */
> -#define DCACHE_WHITEOUT_TYPE		0x00100000 /* Whiteout dentry (stop pathwalk) */
> -#define DCACHE_DIRECTORY_TYPE		0x00200000 /* Normal directory */
> -#define DCACHE_AUTODIR_TYPE		0x00300000 /* Lookupless directory (presumed automount) */
> -#define DCACHE_REGULAR_TYPE		0x00400000 /* Regular file type (or fallthru to such) */
> -#define DCACHE_SPECIAL_TYPE		0x00500000 /* Other file type (or fallthru to such) */
> -#define DCACHE_SYMLINK_TYPE		0x00600000 /* Symlink (or fallthru to such) */
> +/* Negative dentry (maybe fallthru to nowhere) */
> +#define DCACHE_MISS_TYPE		0x00000000
> +/* Whiteout dentry (stop pathwalk) */
> +#define DCACHE_WHITEOUT_TYPE		0x00100000
> +/* Normal directory */
> +#define DCACHE_DIRECTORY_TYPE		0x00200000
> +/* Lookupless directory (presumed automount) */
> +#define DCACHE_AUTODIR_TYPE		0x00300000
> +/* Regular file type (or fallthru to such) */
> +#define DCACHE_REGULAR_TYPE		0x00400000
> +/* Other file type (or fallthru to such) */
> +#define DCACHE_SPECIAL_TYPE		0x00500000
> +/* Symlink (or fallthru to such) */
> +#define DCACHE_SYMLINK_TYPE		0x00600000

Please leave things like this as they were.

> - * d_really_is_negative - Determine if a dentry is really negative (ignoring fallthroughs)
> + * d_really_is_negative - Determine if a dentry is really negative (ignoring
> + * fallthroughs)

Does that break doc generation?

Is fudging the comments actually worth breaking git blame?

> -static inline int simple_positive(struct dentry *dentry)
> +static inline bool simple_positive(struct dentry *dentry)

This is worth doing - gcc actually produces better code sometimes with the int
-> bool switch.  This should be a separate patch.

David