Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option

From: Hannes Frederic Sowa
Date: Mon Jan 11 2016 - 07:19:47 EST

On 11.01.2016 07:50, Michal Kubecek wrote:
Commit acf8dd0a9d0b ("udp: only allow UFO for packets from SOCK_DGRAM
sockets") disallows UFO for packets sent from raw sockets. We need to do
the same also for SOCK_DGRAM sockets with SO_NO_CHECK options, even if
for a bit different reason: while such socket would override the
CHECKSUM_PARTIAL set by ip_ufo_append_data(), gso_size is still set and
bad offloading flags warning is triggered in __skb_gso_segment().

In the IPv6 case, SO_NO_CHECK option is ignored but we need to disallow
UFO for packets sent by sockets with UDP_NO_CHECK6_TX option.

Signed-off-by: Michal Kubecek <mkubecek@xxxxxxx>
Tested-by: Shannon Nelson <shannon.nelson@xxxxxxxxx>

Acked-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>