Re: [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup

From: Viresh Kumar
Date: Mon Jan 11 2016 - 09:09:03 EST


On 11-01-16, 13:04, Mans Rullgard wrote:
> Commit 61e183f83069 ("dmaengine/dw_dmac: Reconfigure interrupt and
> chan_cfg register on resume") moved some channel initialisation to
> a new function which must be called before starting a transfer.
>
> This updates dw_dma_cyclic_start() to use dwc_dostart() like the other
> modes, thus ensuring dwc_initialize() gets called and removing some code
> duplication.
>
> Fixes: 61e183f83069 ("dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg register on resume")
> Signed-off-by: Mans Rullgard <mans@xxxxxxxxx>
> ---
> Changes:
> - replace duplicated code by dwc_dostart() call
> ---
> drivers/dma/dw/core.c | 23 +----------------------
> 1 file changed, 1 insertion(+), 22 deletions(-)

Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh