Re: mfd-dm355evm_msp: One function call less in add_child() after error detection
From: SF Markus Elfring
Date: Tue Jan 12 2016 - 03:34:50 EST
>> The platform_device_put() function was called in one case by the
>> add_child() function during error handling even if the passed
>> variable "pdev" contained a null pointer.
>> Implementation details could be improved by the adjustment of jump targets
>> according to the Linux coding style convention.
>> This issue was detected by using the Coccinelle software.
>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> drivers/mfd/dm355evm_msp.c | 21 ++++++++++-----------
>> 1 file changed, 10 insertions(+), 11 deletions(-)
> Same comments as before.
To which comments do you refer here?
Are you interested in any further clarification of open issues?