Re: [PATCH v15 02/25] tools: Make list.h self-sufficient
From: Borislav Petkov
Date: Tue Jan 12 2016 - 07:35:59 EST
On Fri, Dec 18, 2015 at 06:39:16AM -0600, Josh Poimboeuf wrote:
> Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel
nitpick: we like to do this commit quoting style:
7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")
Checkpatch catches that:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")'
Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel
> version of list.h, which broke the stacktool build because the tools
> list.h includes the kernel list.h.
> Avoid this type of situation in the future and make list.h
> self-sufficient by copying the kernel list.h routines directly into
> tools list.h.
> This is a straight copy except for adjustments to the include statements
> and copying of the tools-specific list routines (list_del_range and
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> tools/include/linux/list.h | 753 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 747 insertions(+), 6 deletions(-)
ECO tip #101: Trim your mails when you reply.