Re: [PATCH-v2 4/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl
From: Christoph Hellwig
Date: Tue Jan 12 2016 - 10:09:48 EST
> +++ b/drivers/target/target_core_tpg.c
> @@ -75,9 +75,16 @@ struct se_node_acl *core_tpg_get_initiator_node_acl(
> unsigned char *initiatorname)
> struct se_node_acl *acl;
> + /*
> + * Obtain the acl_kref now, which will be dropped upon the
> + * release of se_sess memory within transport_free_session().
> + */
As said before this is incorrect, or rather shold be incorrect. I
think it should be removed, but if you want to keep it should be
in core_tpg_check_initiator_node_acl and not here.
The call of core_tpg_get_initiator_node_acl in
iscsit_build_sendtargets_response needs a put to balance out the
get of this kref while we're at it.