Re: [PATCH 1/3] ifb: make device count build-time configurable

From: Daniel Borkmann
Date: Tue Jan 12 2016 - 11:04:35 EST

On 01/12/2016 04:43 PM, Lubomir Rintel wrote:
On Tue, 2016-01-12 at 16:35 +0100, Daniel Borkmann wrote:
On 01/12/2016 04:19 PM, Daniel Borkmann wrote:
On 01/12/2016 12:56 PM, Lubomir Rintel wrote:
-static int numifbs = 2;
+static int numifbs = CONFIG_IFB_COUNT;
module_param(numifbs, int, 0);
MODULE_PARM_DESC(numifbs, "Number of ifb devices");

Btw, perhaps there should also be a pr_info() or the like to warn the user
that relying on modprobe creating these devs is deprecated and scheduled
for removal in future, so they should switch to ip link instead ...

I don't know, is it actually is scheduled for removal?

I was under impression that changes in default behavior users can rely
on are generally near impossible to do since the potential problems
largely outweigh the benefits. The distributions will do the changes in
their kernels anyway and changing behavior on kernel upgrades in random
old systems might be risky.

BLK_DEV_LOOP_MIN_COUNT is 8 by default on upstream today, 0 in Fedora kernels
since Fedora 19 (2013) onwards [1] (F18 to F19 made the switch apparently).

If the same happens one day to these options here and all major distros
play along, then perhaps after still long enough time it might be an option
(and if not, people at least switched to use ip link ;)).

That said, it's just an impression. I don't follow the development
closely enough to be sure about anything.