Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c

[Yury Norov]

On Fri, Jan 08, 2016 at 10:08:44AM +0100, Arnd Bergmann wrote:
> On Friday 08 January 2016 02:34:29 Yury Norov wrote:
> > +
> > +#include "../../../fs/compat_binfmt_elf.c"
> > 
> 
> This is the wrong file, you have to include fs/binfmt_elf.c, otherwise
> you pick up the same definitions that you have for the other one.
> 

I chose compat as it's how it wokrs now. It redefines some types like
user_long_t, and I think it's neccessary for ILP32, as for aarch32.

> Alternatively, you can also change binfmt_elf32.c to include fs/binfmt_elf.c
> and use fs/compat_binfmt_elf.c here if that makes the code nicer, you
> just can use the compat file for both or things get ugly because of
> the extra indirections.
> 
> 	Arnd