Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

From: Borislav Petkov
Date: Tue Jan 12 2016 - 11:53:18 EST


On Fri, Dec 18, 2015 at 06:39:29AM -0600, Josh Poimboeuf wrote:
> aesni-intel_asm.S has several callable non-leaf functions which don't
> honor CONFIG_FRAME_POINTER, which can result in bad stack traces.
>
> Create stack frames for them when CONFIG_FRAME_POINTER is enabled.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Mathias Krause <minipli@xxxxxxxxxxx>
> ---
> arch/x86/crypto/aesni-intel_asm.S | 73 ++++++++++++++++++++++++---------------
> 1 file changed, 46 insertions(+), 27 deletions(-)

After this one it says

stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init(): can't find starting instruction
stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init()+0x24: return instruction outside of a callable function

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.