Re: [PATCH v15 00/25] Compile-time stack metadata validation

From: Borislav Petkov
Date: Tue Jan 12 2016 - 12:17:48 EST

On Fri, Dec 18, 2015 at 06:39:14AM -0600, Josh Poimboeuf wrote:
> This is v15 of the compile-time stack metadata validation patch set,
> along with proposed fixes for many of the warnings it found. It's based
> on the tip/master branch.


Reviewed-by: Borislav Petkov <bp@xxxxxxx>

With it applied, my .config gives ~1000 stacktool warnings.

One of the issues that bugs me recently is adding tool-specific markers
to unrelated code and new tools tend to love doing that. But this makes
unrelated code ugly and people touching it shouldn't have to know about
those tools.

I guess you could improve the analysis of vmlinux as stacktool is
running post-compile and thus put the onus on the tool to do the right
thing and not on the code.

But that's for the TODO.



ECO tip #101: Trim your mails when you reply.