Re: [PATCH] mm/memblock: If nr_new is 0 just return

[Andrew Morton]

On Sat,  9 Jan 2016 06:33:40 -0500 nimisolo <nimisolo@xxxxxxxxx> wrote:

> If nr_new is 0 which means there's no region would be added,
> so just return to the caller.
> 
> ...
>
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -588,6 +588,9 @@ repeat:
>  					       nid, flags);
>  	}
>  
> +	if (!nr_new)
> +		return 0;
> +
>  	/*
>  	 * If this was the first round, resize array and repeat for actual
>  	 * insertions; otherwise, merge and return.

hm, why?  Is there something actually wrong with the current code?

Under what circumstances does nr_new==0 actually happen?  Is it a bug
in the caller?