Re: [PATCH] net: phy: turn carrier off on phy attach

From: Florian Fainelli
Date: Tue Jan 12 2016 - 20:31:16 EST

On January 9, 2016 10:44:05 AM PST, Sjoerd Simons <sjoerd.simons@xxxxxxxxxxxxxxx> wrote:
>The operstate of a networking device initially IF_OPER_UNKNOWN aka
>"unknown", updated on carrier state changes (with carrier state being
>by default). This means it will stay unknown unless the carrier state
>goes to off at some point, which is not the case if the phy is already
>up/connected at startup.

Correct, drivers typically call netif_carrier_off prior to registering the network device to give a predictable link state, regardless of whether or not they use PHYLIB.

>Explicitly turn off the carrier on phy attach, leaving the phy state
>machine to turn the carrier on when it has done the initial

Same comment as Andrew on the comment below.

Out of curiosity, was there a particular driver you ran into issues with?