Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP

From: Laxman Dewangan
Date: Tue Jan 12 2016 - 23:35:43 EST



On Wednesday 13 January 2016 09:58 AM, Krzysztof Kozlowski wrote:
On 13.01.2016 13:07, Laxman Dewangan wrote:
On Wednesday 13 January 2016 05:36 AM, Krzysztof Kozlowski wrote:

That is also fine to me but still I am not comfortable with the config
name and driver file name as this does not suggest the common.
The name does not matter. Really. We have a lot of drivers with a
specific device-like name and supporting different devices. To point
that your argument is invalid - your initial name of driver
"rtc-max77620.c" supported totally different "names": the max77620 and
max20024. It also wasn't suggesting something "common"...
In all config string, I have mentioned the MAX20024.


With my approach we are not developing common think neither. We just
want to extend/re-use existing max77686 (or max77802) driver for new
devices. Just like everywhere else.

OK, fine to me if this is acceptable.
I will drop this rtc patch form this series and work in max77686 driver to modify first and once merged, use this config on my defconfig.