Re: [PATCH] perf tools: Do not show trace command if it's not compiled in
From: Ingo Molnar
Date: Wed Jan 13 2016 - 05:43:09 EST
* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> Em Tue, Jan 12, 2016 at 12:23:41PM +0100, Ingo Molnar escreveu:
> > * Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > > The trace command still appears in help message when you
> > > run simple 'perf' command.
> > >
> > > It's because the generate-cmdlist.sh does not care about the
> > > HAVE_LIBAUDIT_SUPPORT dependency of trace command and puts
> > > it into generated common_cmds array.
> > >
> > > Wrapping trace command under HAVE_LIBAUDIT_SUPPORT dependency,
> > > which will exclude it from common_cmds array if HAVE_LIBAUDIT_SUPPORT
> > > is not set.
> > Btw., would it make sense to still list them, but denote them as '[NOT BUILT IN]':
> Yeah, just like we have:
> $ make NO_DWARF=1 O=/tmp/build/perf -C tools/perf/ install
> make: Entering directory '/home/git/linux/tools/perf'
> BUILD: Doing 'make -j4' parallel build
> config/Makefile:328: DWARF support is off, BPF prologue is disabled
> SUBDIR Documentation
> ASCIIDOC /tmp/build/perf/perf-diff.xml
> CC /tmp/build/perf/util/abspath.o
> $ perf record -h vm build
> Usage: perf record [<options>] [<command>]
> or: perf record [<options>] -- <command> [<options>]
> -B, --no-buildid do not collect buildids in perf.data
> -N, --no-buildid-cache do not update the buildid cache
> --vmlinux <file> vmlinux pathname
> (not built-in because NO_DWARF=1)