Re: [PATCH] gpio: generic: make bgpio_pdata always visible

From: Linus Walleij
Date: Wed Jan 13 2016 - 10:01:25 EST

On Sat, Jan 9, 2016 at 10:16 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> Board files that define their own bgpio_pdata are broken when
> CONFIG_GPIO_GENERIC is disabled and the bgpio_pdata structure
> definition is hidden by the #ifdef:
> arch/arm/mach-clps711x/board-autcpu12.c:148:15: error: variable 'autcpu12_mmgpio_pdata' has initializer but incomplete type
> static struct bgpio_pdata autcpu12_mmgpio_pdata __initdata = {
> arch/arm/mach-clps711x/board-autcpu12.c:149:2: error: unknown field 'base' specified in initializer
> Since the board files should generally not care what drivers are
> enabled, this makes the structure definition visible again.
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")

Thanks a lot, patch applied!

Linus Walleij