Re: [PATCH] ld-version: fix it on Fedora

From: James Hogan
Date: Wed Jan 13 2016 - 12:05:51 EST


Cc'ing Daniel, who has hit further breakage due to unusual version numbers.

On 7 January 2016 at 17:55, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> On Fedora 23, ld --version outputs:
> GNU ld version 2.25-15.fc23
>
> But ld-version.sh fails to parse this, so e.g. mips build fails to
> enable VDSO, printing a warning that binutils >= 2.24 is required.
>
> To fix, teach ld-version to parse this format.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
>
> Which tree should this be merged through? Mine? MIPS?
>
> scripts/ld-version.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/ld-version.sh b/scripts/ld-version.sh
> index 198580d..25d23c8 100755
> --- a/scripts/ld-version.sh
> +++ b/scripts/ld-version.sh
> @@ -2,6 +2,8 @@
> # extract linker version number from stdin and turn into single number
> {
> gsub(".*)", "");
> + gsub(".*version ", "");
> + gsub("-.*", "");
> split($1,a, ".");
> print a[1]*10000000 + a[2]*100000 + a[3]*10000 + a[4]*100 + a[5];
> exit
> --
> MST
>