Re: [PATCH] ata: add AMD Seattle platform driver

From: Brijesh Singh
Date: Wed Jan 13 2016 - 12:12:44 EST


On 01/12/2016 08:24 AM, Arnd Bergmann wrote:
>>> Isn't this the thing that ACPI based firmware would handle using AML anyway?
>>> I don't think the server people would be too happy to add a new driver
>>> each time a SATA controller does the LEDs slightly differently, and this
>>> is really the kind of platform specific hack that AML is meant for.
>> Sorry I am not able understand your comment, Could you please explain me what you mean by AML is meant for this kind of platform specific hack ?
> I meant the sgpio register should not be exposed through a resource on
> an ACPI based system but the access be hidden behind a call into an AML
> method.
> You basically extend the generic AHCI driver to understand three ways of
> blinking the LEDS:
> a) standard AHCI enclosure management
> b) the Linux LED subsystem using whatever LED implementation the platform provides

Yes I could look into exploring LED implementation for DT case.

> c) calling into the ACPI interpreter to do platform specific hacks

Thanks for explaining. Now I understood your comment on AML however we need to consider the following:

a) activity LED blinking routines are called very frequent (10 to 100ms based on emp->state) and executing AML method that often would introduces its own overhead.

b) all BIOS vendors need to implement a new methods in their DSDT and release a new BIOS.

c) other OS'es (mainly Windows) driver need to be updated.

We don't know how many other SoC's have similar hacky implementation which can take advantage of extending generic
AHCI driver to call into AML methods for LED blink. Given some of these causes I think having a platform driver is much cleaner. I can drop DT binding part from this driver and keep just ACPI binding.

Thoughts ?


> Arnd