Re: [PATCH] perf tools: Fix reading of build-id from vDSO

[Arnaldo Carvalho de Melo]

Em Wed, Jan 13, 2016 at 05:23:01PM +0000, Ben Hutchings escreveu:
> We need to use the long name (the filename) when reading the build-id
> from a DSO.  Using the short name doesn't work for (at least) vDSOs.

Thanks, we should really prefer the long_name, applied.

- Arnaldo
 
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
>  tools/perf/util/symbol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index cd08027..b60bc49 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -1465,7 +1465,7 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter)
>  	 * Read the build id if possible. This is required for
>  	 * DSO_BINARY_TYPE__BUILDID_DEBUGINFO to work
>  	 */
> -	if (filename__read_build_id(dso->name, build_id, BUILD_ID_SIZE) > 0)
> +	if (filename__read_build_id(dso->long_name, build_id, BUILD_ID_SIZE) > 0)
>  		dso__set_build_id(dso, build_id);
>  
>  	/*