Re: [PATCH v2 2/2] powercap/rapl: reduce ipi calls
From: Borislav Petkov
Date: Wed Jan 13 2016 - 17:29:57 EST
On Wed, Jan 13, 2016 at 02:20:07PM -0800, Jacob Pan wrote:
> To me the caller code became more readable.
Not to me.
> I think you are referring the function name being not readable, which
> is separate of this conversion.
You think wrong.
I typed in the example and commented right under it. The old code is
much more understandable than the new code. The old code shows what bits
get set and cleared, the new code uses masks, sometimes hidden behind
defines, which people have to look up to understand what's going on. And
then look at the function definition to know which arg which is. And so
on and so on...
But I'm going to stop wasting my time with this now. I gave you enough
ECO tip #101: Trim your mails when you reply.