Re: [PATCH 2/2] soc: versatile: Drop a useless static qualifier

From: Linus Walleij
Date: Thu Jan 14 2016 - 04:12:52 EST


On Mon, Jan 11, 2016 at 7:16 AM, Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:

> There is no need to have the 'struct regmap *syscon_regmap' variable
> static in the probe function.
> It only wastes a few bytes of memory.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Sorry a copy-paste error ... used to have it as a global.

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I think you should send this to arm@xxxxxxxxxx for application
as a fixup to the ARM SoC tree. Include my Review tag.

Yours,
Linus Walleij