Re: [PATCH] dell-wmi: Stop storing pointers to DMI tables

From: MichaÅ KÄpieÅ
Date: Thu Jan 14 2016 - 04:52:15 EST


> > Hi Andy, I looked at this patch, but I think some people from -mm or DMI
> > code should look at it as it is memory problem... We also has one in
> > dell-laptop.ko (wrong API usage) and so -mm people could know it better.

> There are at least two platform drivers (dell-wmi and dell-laptop)
> that don't play well with the current interface. This patch is
> intended to fix one of them.

Pali, Andy,

Could you point out the exact place where dell-laptop errs? AFAICT, it
only has one use of dmi_walk(), the callback there calls
parse_da_table(), which does the right thing, i.e. krealloc()'ing memory
and then memcpy()'ing table contents there...

--
Best regards,
MichaÅ KÄpieÅ