Re: [PATCH 0/2] mm: memcontrol: cgroup2 memory statistics
From: Johannes Weiner
Date: Thu Jan 14 2016 - 15:24:56 EST
On Wed, Jan 13, 2016 at 02:49:16PM -0800, Andrew Morton wrote:
> It would be nice to see example output, and a description of why this
> output was chosen: what was included, what was omitted, why it was
> presented this way, what units were chosen for displaying the stats and
> why. Will the things which are being displayed still be relevant (or
> even available) 10 years from now. etcetera.
> And the interface should be documented at some point. Doing it now
> will help with the review of the proposed interface.
> Because this stuff is forever and we have to get it right.
Here is a follow-up to 1/2 that hopefully addresses all that, as well
as the 32-bit overflow problem. What do you think? I'm probably a bit
too optimistic with being able to maintain a meaningful sort order of
the file when adding new entries. It depends on whether people start
relying on items staying at fixed offsets and what we tell them in
response when that breaks. I hope that we can at least get the main
memory consumers in before this is released, just in case.