Re: [PATCH 5/5] x86/mcheck/AMD: Set MCAX Enable bit
From: Borislav Petkov
Date: Thu Jan 14 2016 - 17:59:06 EST
On Thu, Jan 14, 2016 at 04:53:58PM -0600, Aravind Gopalakrishnan wrote:
> Well McaX is name of the field in the MSR. I retained the "SMCA" prefix as
What does that McaX mean, btw?
> these are all still part of the ScalableMCA changes.
> I would prefer if "MCAX" is retained as it is indicative of which bit we are
> touching. So how about just MCAX_EN_OFF ?
If we're going to have a bunch of defines belonging to SMCA, then we're
better having them all start with SMCA_ after all, I guess.
But please make sure you have comments over their definitions explaining
what those bits are. When an outsider is reading those patches and SMCA,
MCAX start appearing left and right, his head most likely starts to
ECO tip #101: Trim your mails when you reply.