RE: [PATCH v4] surface pro 4: Add support for Surface Pro 4 Buttons
From: Chen, Yu C
Date: Thu Jan 14 2016 - 20:50:28 EST
Hi Darren, Xuetian
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx]
> Sent: Friday, January 15, 2016 7:01 AM
> To: Weng Xuetian
> Cc: Chen, Yu C; linux-kernel@xxxxxxxxxxxxxxx; platform-driver-
> Subject: Re: [PATCH v4] surface pro 4: Add support for Surface Pro 4 Buttons
> On Tue, Jan 12, 2016 at 11:43:55AM -0800, Weng Xuetian wrote:
> > Surface Pro 4 buttons are managed by a device with _HID "MSHW0040"
> > different from Surface Pro 3.
> > This commit adds MSHW0040 to id list to support the Surface Pro 4.
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=109871
> > Signed-off-by: Weng Xuetian <wengxt@xxxxxxxxx>
> This is so much better, thank you Weng.
> Yu, are you happy with this version?
One minor nit below, other than that,
Acked-by: Chen Yu <yu.c.chen@xxxxxxxxx>
-- #define SURFACE_BUTTON_DEVICE_NAME "Surface Pro 3 Buttons"
++ #define SURFACE_BUTTON_DEVICE_NAME "Surface Pro 3/4 Buttons"