Re: [PATCH v15 13/25] x86/reboot: Add ljmp instructions to stacktool whitelist
From: Ingo Molnar
Date: Fri Jan 15 2016 - 06:13:55 EST
* Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Fri, Jan 15, 2016 at 12:00:00PM +0100, Ingo Molnar wrote:
> > All of the cases Josh listed involve some sort of special case where we do
> > something non-standard. (Where 'standard' == 'regular kernel C function'.)
> My only worry is that next time we have to do something non-standard,
> we'll have to annotate it as well. bpf_jit case-in-point.
but that's generally OK: it's not a problem if something non-standard is visibly
non-standard on the source code level as well.
> OTOH, I guess the generic, tool-agnostic annotation could be a step in the
> (more-)right direction as we're saying "we're doing something special here, and
> we're stating that fact with this here annotation."
Yeah, I think so too!