Re: kvm: access to invalid memory in mmu_zap_unsync_children

[Paolo Bonzini]

On 15/01/2016 17:54, Sasha Levin wrote:
> Hi all,
> 
> While fuzzing with syzkaller on the latest -next kernel running on a KVM tools
> guest, I've hit the following invalid memory access:
> 
> [  547.956284] UBSAN: Undefined behaviour in arch/x86/kvm/mmu.c:2011:17
> 
> [  547.956940] index 3 is out of range for type 'kvm_mmu_page *[3]'
> 
> [  547.957567] CPU: 0 PID: 21577 Comm: syz-executor Tainted: G      D         4.4.0-next-20160114-sasha-00021-gf1273d1-dirty #2798
> 
> [  547.958739]  1ffff1001819be5c 000000002fa0e55b ffff8800c0cdf360 ffffffff83433c4e
> 
> [  547.972448]  0000000041b58ab3 ffffffff8f960c38 ffffffff83433b86 ffff8800c0cdf328
> 
> [  547.973277]  0000000000000001 000000002fa0e55b ffffffff8feb8440 ffff8800c0cdf3f0
> 
> [  547.974102] Call Trace:
> 
> [  547.974424] dump_stack (lib/dump_stack.c:52)
> [  547.975774] ubsan_epilogue (lib/ubsan.c:165)
> [  547.976408] __ubsan_handle_out_of_bounds (lib/ubsan.c:382)
> [  547.980877] mmu_zap_unsync_children (arch/x86/kvm/mmu.c:2011 arch/x86/kvm/mmu.c:2272)

Marcelo/Takuya/Xiao,

do you know what's the point in the assignment in kvm_mmu_pages_init?

It seems to me that it should be

	parents->parent[0] = NULL;

since the only user of the ->parent[] array, mmu_pages_clear_parents,
walks the array up from parents->parent[0].

Any other opinions?

Paolo