Re: [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic
Date: Mon Jan 18 2016 - 03:27:01 EST
On 2016/1/16 2:07, Mark Brown wrote:
> On Tue, Jan 12, 2016 at 10:18:03AM +0800, chenfeng wrote:
>> On 2016/1/12 2:24, Mark Brown wrote:
>>> On Mon, Jan 11, 2016 at 08:20:16PM +0800, Chen Feng wrote:
>>>> +config REGULATOR_HI655X
>>>> + tristate "Hisilicon HI655X PMIC regulators support"
>>>> + depends on ARCH_HISI || (COMPILE_TEST && ARM64)
>>> Why does this depend on ARM64? If it's needed it probably indicates a
>> There will be compile warning with arch parisc.
>> Add the current support platform is ARM64.
> The whole point of COMPILE_TEST is to allow people who are working
> generally rather than with the particular hardware to build things to
> improve build test coverage when doing general kernel work. A warning
> on a very obscure architecture is really not a blocker here.
ok, I will remove the ARM64 depends.
>> I am not sure about open coding regulators_node.
>> I take max8907-regulator.c for reference. The code there is:
>> 224 static int max8907_regulator_parse_dt(struct platform_device *pdev)
> The existance of older drivers that have not yet been converted to use
> newer core subsystem features is not a good reason to avoid using those
> core subsystem features. You'll commonly find this situation in the
>> Can you give me some references? Really thanks for your help.
> $ grep -l regulators_node drivers/regulator/*.c
Understand, I will remove the match-table and add the regulators_node
to match the regulator-compatible in dts.